-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nmt and nmd from Nixpkgs #4884
Conversation
0917534
to
846200e
Compare
This makes it IFD again, isn't it? Should I open a new issue?
|
@oxalica Hmm, not sure. It works fine without |
Would it work if the packages were fixed-output derivations? It should be possible to fix their output since they don't really have any dependencies. |
See NixOS/nixpkgs#281111. Hopefully that would fix this issue. |
https://discourse.nixos.org/t/is-nix-lib-nmd-missing-from-23-11/38268 In my dev container, to reduce disk space, I use the 23.11 tag, not the updated channel. This means that now home-manager has to be pinned at the commit before this one. I'd say it's a little surprising that "release-23.11" is not compatible with nixos tag 23.11. I tend to think we should be backwards compatible at least for half a year (one release cadence). |
@iphydf I definitely would suggest not pinning to the 23.11 tag, it will never be updated, even for security reasons. I would instead suggest pinning to a suitable commit hash along the history of the 23.11 channel and occasionally consider updating the pin. That said, if there is a big demand for it, then we could revert the HM 23.11 branch back to using the Sourcehut source since it is available again. |
I'm still seeing IFD errors, even with the latest
Curiously, this only happens when I eval on my |
I'll pin the commit hash. It's not super important to be up to date because it's only used for integration tests and our local dev environment, not for releases, but I think using commit hashes will work for us. |
Turns out pulling nmt and nmd from Nixpkgs causes an IFD, even when the packages are fixed-output derivations. Thus, since Sourcehut is up and well, we can revert to simply fetching nmd and nmt directly. See discussion in <#4884>.
Ok, I've opened the above PR to restore the use of fetchTarball for nmd and nmt. Since Sourcehut is available again, I figure it should be safe to switch back. |
I've seen the regression several times. Would it be better to add a CI task to build with |
Turns out pulling nmt and nmd from Nixpkgs causes an IFD, even when the packages are fixed-output derivations. Thus, since Sourcehut is up and well, we can revert to simply fetching nmd and nmt directly. See discussion in <nix-community#4884>.
Description
Fixes #4879
Depends on NixOS/nixpkgs#280467 being in NixOS unstable.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like