jujutsu: Remove superfluous shell completion

[jcf]

This issue has come up before, and the recommendation was to remove the shell completion logic from Home Manager. This pull request now does just that.

• cli: use a positional argument for jj util completion martinvonz/jj#2945
• jujutsu: fix completions commands #5016 (comment)
• jujutsu: Remove superfluous shell completion #5037 (review)

Description

$ for sh (--bash --fish --zsh); jj util completion "$sh" >/dev/null
Warning: `jj util completion --bash` will be removed in a future version, and this will be a hard error
Hint: Use `jj util completion bash` instead
Warning: `jj util completion --fish` will be removed in a future version, and this will be a hard error
Hint: Use `jj util completion fish` instead
Warning: `jj util completion --zsh` will be removed in a future version, and this will be a hard error
Hint: Use `jj util completion zsh` instead

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

Maintainer CC

@shikanime

[jcf]

I've tested this locally by overriding the Jujutsu program like so:

programs.jujutsu.enableZshIntegration = false;
programs.zsh.initExtra = ''
  source <(${pkgs.jujutsu}/bin/jj util completion zsh)
    compdef _jj ${pkgs.jujutsu}/bin/jj
'';

[ambroisie]

Duplicate of #5016, and same issue: this shouldn't even be in Home-Manager.

EDIT: I see that #5016 was closed. I would suggest the same thing for this PR as for that one: just remove the option since the package already installs the completion files.

[jcf]

It sounds like the resolution was to remove this completion from Home-Manager. Would such a pull request be welcome?

[jcf]

I've pushed another commit to remove the shell completion entirely.

[rycee]

Thanks! Merged to master now 🙂