-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xonsh: add module and some shell integrations #5160
base: master
Are you sure you want to change the base?
Conversation
Hi, I've finally had a look and the integration with zoxide looks good to me. |
Thanks. By the way, how can I initiate the tests? Should I ping someone or just wait for maintainer approval? |
Sorry, I forgot to use |
Could any maintainer help with the approval please? |
I'm not familiar with xonsh. But I have taken a look of the document, and I think it uses an alias instead of a |
Ah yes, Xonsh does use aliases to make a Pythonic function available as a Shell-like command, and that's why I set the field of In Xonsh, using The But I have to admit |
Could anyone help with workflow approval? |
Description
Add a module for shell Xonsh and some shell integrations for it.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@XYenon for yazi integration
@jpteb for zoxide integration, as the latest editor, since it seems the original maintainer had left the community (sadly)
Do I also need to CC the maintainer of the xonsh package in nixpkgs?