-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hypridle: add module #5324
Hypridle: add module #5324
Conversation
@rycee Does the program config need to be separated from the systemd service config? |
I believe it's best to reuse the nix to hyprlang translator that the hyprland module uses. Perhaps externalize it to a separate file/lib function. That way, we won't have to constantly change the module options each time an option is added/renamed/removed. |
Makes sense, I'll take a look at that. |
6ad5b3b
to
c526714
Compare
Thanks for the contribution! I've added a few comments. |
001b3f2
to
8043fa2
Compare
4b05a9f
to
0b7d94a
Compare
5271b3a
to
67b2e53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rycee anything else we need to change in these modules or do they look good now? |
Thanks! Merged to master now 🙂 |
…nity/home-manager/pull/5324 (clashes with enabling it locally)
Description
Adding hypridle module so i can remove another input from my flake and just use the config in home-manager. Meant to do a long time ago but forgot to create PR.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@fufexan