Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypridle: add module #5324

Merged
merged 1 commit into from
May 5, 2024
Merged

Hypridle: add module #5324

merged 1 commit into from
May 5, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Apr 23, 2024

Description

Adding hypridle module so i can remove another input from my flake and just use the config in home-manager. Meant to do a long time ago but forgot to create PR.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@fufexan

@khaneliman khaneliman changed the title Hypridle Hypridle: add module Apr 23, 2024
@khaneliman
Copy link
Contributor Author

khaneliman commented Apr 23, 2024

@rycee Does the program config need to be separated from the systemd service config?

@khaneliman khaneliman mentioned this pull request Apr 23, 2024
6 tasks
@fufexan
Copy link
Contributor

fufexan commented Apr 26, 2024

I believe it's best to reuse the nix to hyprlang translator that the hyprland module uses. Perhaps externalize it to a separate file/lib function.

That way, we won't have to constantly change the module options each time an option is added/renamed/removed.

@khaneliman
Copy link
Contributor Author

I believe it's best to reuse the nix to hyprlang translator that the hyprland module uses. Perhaps externalize it to a separate file/lib function.

That way, we won't have to constantly change the module options each time an option is added/renamed/removed.

Makes sense, I'll take a look at that.

modules/lib/maintainers.nix Outdated Show resolved Hide resolved
modules/services/hypridle.nix Outdated Show resolved Hide resolved
modules/services/hypridle.nix Outdated Show resolved Hide resolved
@rycee
Copy link
Member

rycee commented Apr 27, 2024

Thanks for the contribution! I've added a few comments.

Copy link
Contributor

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khaneliman
Copy link
Contributor Author

@rycee anything else we need to change in these modules or do they look good now?

@rycee rycee merged commit fdaaf54 into nix-community:master May 5, 2024
3 checks passed
@rycee
Copy link
Member

rycee commented May 5, 2024

Thanks! Merged to master now 🙂

@khaneliman khaneliman deleted the hypridle branch May 5, 2024 11:51
Jappie3 added a commit to Jappie3/Psycronix that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants