Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termite: use vte-ng at pkgs.termite.vte-ng #865

Merged
merged 1 commit into from Oct 12, 2019

Conversation

kalbasit
Copy link
Collaborator

@kalbasit kalbasit commented Oct 8, 2019

depends on NixOS/nixpkgs#70776
closes #864

kalbasit added a commit to kalbasit/shabka that referenced this pull request Oct 8, 2019
@rycee
Copy link
Member

rycee commented Oct 8, 2019

Thanks for the contribution. I've sent you a contributor invite so that you can merge this your self when it's ready. Please have a look at the contribution guidelines if you haven't already and please keep opening PRs for non-trivial changes 👍

@kalbasit
Copy link
Collaborator Author

kalbasit commented Oct 9, 2019

@rycee I merged the PR upstream. Merging this change to master would require nixpkgs to have the commit NixOS/nixpkgs@9dc7b25. How do you want to handle this? Should I piggyback off of config.home.stateVersion?

@rycee
Copy link
Member

rycee commented Oct 10, 2019

I understand that the old code no longer works with master Nixpkgs. If so then I would suggest simply merging this PR once you fix in Nixpkgs has been introduced in the unstable channel. Well, if it doesn't work you can just merge right now since it wouldn't make the situation worse 🙂

@kalbasit kalbasit merged commit b1d8c0f into nix-community:master Oct 12, 2019
@kalbasit kalbasit deleted the expose-vte-ng branch October 12, 2019 18:39
@juripaern0007
Copy link

@kalbasit I'm affected by this. I updated today my nix-channel today but I still have this issue
system and user nix-channel --update && home-manager switch.

What do I need to do, to be able to do a successful home-manager switch?

@kalbasit
Copy link
Collaborator Author

kalbasit commented Oct 31, 2019

@kalbasit I'm affected by this. I updated today my nix-channel today but I still have this issue
system and user nix-channel --update && home-manager switch.

What do I need to do, to be able to do a successful home-manager switch?

What NixOS channel are you on? If you're using 19.09 then you should use the 19.09 branch of home-manager to get this one to work.

jorsn pushed a commit to jorsn/home-manager that referenced this pull request Nov 2, 2019
jorsn pushed a commit to jorsn/home-manager that referenced this pull request Dec 12, 2019
jorsn pushed a commit to jorsn/home-manager that referenced this pull request Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attribute 'vte-ng' missing, at home-manager/modules/programs/termite.nix
3 participants