Only count the users latest review #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, that won't work with later code. |
mweinelt
force-pushed
the
duplicate-reviews-and-retractions
branch
2 times, most recently
from
959cd34
to
459dc40
Compare
mweinelt
commented
Jun 7, 2022
| for review in p_r_reviews: | ||
| if review.state == "APPROVED": | ||
| approvals[review.user] = review | ||
| last_approved_review_date = review.submitted_at |
There was a problem hiding this comment.
This assumes the order of reviews is chronologically, which held true during my tests.
> label-approved
INFO:root:Pulls total: 8
INFO:root:Processing 176175
INFO:root:lastappdate: 2022-06-04 09:21:32
INFO:root:lastcommitdate: 2022-06-04 02:17:11
INFO:root:Removing label '12.approvals: 2' from PR: '176175' https://github.com/NixOS/nixpkgs/pull/176175
Traceback (most recent call last):
File "/nix/store/h8s1yi7jvxcb6kblamiy1d8kzni6p3p6-python3.10-poetry2nix-env-scripts/bin/.label-approved-wrapped", line 13, in <module>
sys.exit(main())
File "/nix/store/v7kl295wwqxgax6gm3zw95aq5zwcgbzg-source/src/label_approved/cli.py", line 156, in main
pr_object.p_r.remove_from_labels(label_to_remove)
File "/nix/store/01h3ndmfxlgf6hklk422alxdzcljadak-python3-3.10.3-env/lib/python3.10/site-packages/github/PullRequest.py", line 809, in remove_from_labels
headers, data = self._requester.requestJsonAndCheck(
File "/nix/store/01h3ndmfxlgf6hklk422alxdzcljadak-python3-3.10.3-env/lib/python3.10/site-packages/github/Requester.py", line 353, in requestJsonAndCheck
return self.__check(
File "/nix/store/01h3ndmfxlgf6hklk422alxdzcljadak-python3-3.10.3-env/lib/python3.10/site-packages/github/Requester.py", line 378, in __check
raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 403 {"message": "Must have admin rights to Repository.", "documentation_url": "https://docs.github.com/rest/reference/issues#remove-a-label-from-an-issue"} |
|
Fixes inflate review count due to a cycle of approve, comment/request changes, approve.
mweinelt
force-pushed
the
duplicate-reviews-and-retractions
branch
from
459dc40
to
3ee35bc
Compare
Artturin
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foxes Inflated review count due to
as seen in NixOS/nixpkgs#176175
Untested