-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle fwupd update capsules #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this cool change!
@dasJ Looks good. Can you maybe provide a happy path test in another PR? :) I think even testing that everything evualates with fwupd on is better than nothing. |
This caused a regression against nixos-unstable.
|
@mweinelt Thanks for reporting. I've reverted this for now. |
I can confirm a slightly modified version of this PR (commit at lilyinstarlight@9404722) and NixOS/nixpkgs#220555 makes this work correctly I just successfully did a BIOS update with secureboot enforcing using a UEFI capsule with fwupd |
@lilyinstarlight PR in nixpkgs is merged. Please create a new pr on the repo. |
I was going to give @dasJ a chance to since they did the harder work, but I've gone ahead and opened #131 now |
Closes #85