modules/nix: use structural settings (Nix RFC 42)
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t184256
requested changes
Jul 5, 2023
| assert isNixAtLeast "2.2"; | ||
| let | ||
|
|
||
| mkValueString = v: |
There was a problem hiding this comment.
Can we reuse the nixpkgs version here?
|
Seems to function fine, please address the comments from the previous review. |
|
Sorry, for late respond. I'm working on an oral presentation for a conference about Nix, and will not be responsive until August. |
|
Oh, sure, no rush, take your time (and consider sharing the talk =). |
|
Are you still interested in mainlining this? |
|
Oh! I almost forgot about this one. |
|
Since then, things like the Nix settings and Nix flake registries have been splitted from |
Port structural settings from nixos/nix-daemon. Adjust the description based on those from previous options and the Home Manager nix.settings option.
ShamrockLee
force-pushed
the
nix-settings
branch
from
d947011
to
3db1fca
Compare
|
#329 demonstrates the possible strategy to reuse the upstream macro files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ports the structural settings from nixos/nix-daemon (NixOS/nixpkgs#139075) and adjust the description based on those from previous options and the Home Manager nix.settings option (nix-community/home-manager#2718).
If applied, users could specify their
nix.confconfiguration in a structural way, using attribute names identical to the official documentation of Nix, and merge the corresponding attributes from different modules. We don't have to add or change any of the attributes manually whennix.confconfiguration options are added / changed upstream given that the configuration format is kept consistent.The specified configurations are automatically checked using the specified Nix package. The checks can be partially or fully opt out with the
checkAllErrorandcheckConfigoptions.