Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "waybar fix build" #412

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

Scrumplex
Copy link
Member

This reverts commit 30ddf75.

nixpkgs spdlog uses spdlog_9 as its input now.

See NixOS/nixpkgs@48c25dc

This reverts commit 30ddf75.
Copy link

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxhbr
Copy link

maxhbr commented Jul 25, 2023

This fixes the built for me. But does that cause issues on systems that do not use unstable or master nixpkgs?

@Scrumplex
Copy link
Member Author

I think this repo is intended to be used only with nixos-unstable.

@SrEstegosaurio
Copy link
Contributor

SrEstegosaurio commented Sep 11, 2023

I'm encountering this issue and I'm using latest commit available in both nixpkgs unstable and nixpkgs-wayland.
How can this be? I wasn't aware of this issue because apparently I had my nixpkgs-wayland input pinned for a long time.

Nixpkgs-wayland commit: 8d51b54

@Artturin
Copy link
Member

Artturin commented Sep 11, 2023

The CI builds and the nixpkgs input is at db9208ab987cdeeedf78ad9b4cf3c55f5ebd269b (newest unstable), So it should be an issue on your side.

@SrEstegosaurio
Copy link
Contributor

Indeed, my nixpkgs input is set to db9208ab987cdeeedf78ad9b4cf3c55f5ebd269b.
I just went and re-run nix flake update but it seams to change nothing.

@SrEstegosaurio
Copy link
Contributor

SrEstegosaurio commented Sep 11, 2023

The error message in question:

       error: function 'anonymous lambda' called with unexpected argument 'fmt'

       at /nix/store/9incrwprw2s90minyy0gpmwbxmrkcx1v-source/pkgs/development/libraries/spdlog/default.nix:1:1:

            1| { lib
             | ^
            2| , stdenv
       Did you mean fmt_9?

@Artturin
Copy link
Member

spdlog fmt was recently unpinned but it shouldn't affect us because we're not overriding NixOS/nixpkgs@c515312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants