Merge pull request #1689 from malteneuss/tensorflow-macos-tensorflow-…

…dependency
nix-community · Jun 9, 2024 · 304f823 · 304f823
2 parents 7f3af42 + edaf3d8
commit 304f823
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/overrides/default.nix b/overrides/default.nix
@@ -144,6 +144,11 @@ lib.composeManyExtensions [
         doCheck = false;
         cmakeFlags = old.cmakeFlags or [ ] ++ [ "-DBUILD_PYTHON_BINDINGS=OFF" ];
       });
+      tensorflowAttrs = {
+        postInstall = ''
+          rm $out/bin/tensorboard
+        '';
+      };
     in
 
     {
@@ -3500,17 +3505,16 @@ lib.composeManyExtensions [
       );
 
       tensorflow = prev.tensorflow.overridePythonAttrs (
-        _old: {
-          postInstall = ''
-            rm $out/bin/tensorboard
-          '';
-        }
+        _old: tensorflowAttrs
       );
 
       tensorflow-macos = prev.tensorflow-macos.overridePythonAttrs (
-        _old: {
-          inherit (final.tensorflow) postInstall;
-        }
+        # Alternative tensorflow community package for MacOS only.
+        #
+        # We don't want to create an implicit dependency on the normal
+        # tensorflow package, because some versions don't exist for MacOS,
+        # especially ARM Macs.
+        _old: tensorflowAttrs
       );
 
       tensorpack = prev.tensorpack.overridePythonAttrs (