Fix moduleName not being applied for accessing python pkgs set #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cannot reproduce CI eval failure, |
|
Pinging this, would like to get it merged soon :) |
adisbladis
force-pushed
the
missingModuleName
branch
2 times, most recently
from
798dc3e
to
8d50703
Compare
Some wheels are not available for python 3.8 which is the default on unstable now.
adisbladis
force-pushed
the
missingModuleName
branch
from
8d50703
to
352eff7
Compare
|
The test failures were not related to this PR at all. They were caused by the recent nixpkgs bump to Python 3.8 where not all packages used by the tests have wheels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126, was an oversight in #87
Note that moduleName is being applied to define the python pkgs overlay in
poetry2nix/default.nix
Line 113 in e7c69a2
Ping @adisbladis @domenkozar @suryasr007