Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't set #[deny(warnings)] outside of CI #2423

Closed
tbu- opened this issue Jun 3, 2024 · 1 comment · Fixed by #2424
Closed

Shouldn't set #[deny(warnings)] outside of CI #2423

tbu- opened this issue Jun 3, 2024 · 1 comment · Fixed by #2424

Comments

@tbu-
Copy link
Contributor

tbu- commented Jun 3, 2024

It's brittle against new compiler versions (they might introduce new warnings) and also concretely stopped crater from finding a regression in a Rust change: rust-lang/rust#125875 (comment).
tbu- added a commit to tbu-/rust-nix that referenced this issue Jun 3, 2024
@tbu-
Don't deny(warnings) outside of CI
635e9c2 
This allows the tests to continue compiling in new Rust versions, even
if new warnings are added.

Fixes nix-rust#2423.
@tbu- tbu- mentioned this issue Jun 3, 2024
Merged
@asomers
Copy link
Member

asomers commented Jun 3, 2024

Yes, good point. We should switch to using -Dwarnings in CI instead.

github-merge-queue bot pushed a commit that referenced this issue Jun 3, 2024
@tbu-
Don't deny(warnings) outside of CI (#2424)
0cad6cf 
This allows the tests to continue compiling in new Rust versions, even
if new warnings are added.

Fixes #2423.
@RalfJung RalfJung mentioned this issue Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't deny(warnings) outside of CI tbu-/rust-nix
2 participants
@asomers @tbu-