Migrate all FFI declarations to libc #748
Comments
|
We're currently looking really good for this. The big stopper now is the rest of the FFI types for |
bors bot
added a commit
that referenced
this issue
Dec 20, 2017
648: Fix `struct msghdr` types on non-Linux platforms. r=Susurrus a=kinetiknz Type `struct msghdr` and `struct cmsghdr` types defined in `sys/socket/ffi.rs` match the Linux headers, but differ from the standard header (and other OSes): http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html This PR fixes a memory corruption/unsafety issue on non-Linux machines when using `recvmsg` with certain parameters. While fixing this, I wondered what the reason was for nix not using libc's definition of these structures. Closes #748.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should remove all FFI declarations within
nixin favor of types defined in thelibccrate. Much of this work has already been done recently, but there's still some left. And since we don't let any new PRs be merged untillibcsupport has been added, we can resolve this problem relatively easily.Left to address:
src/sys/socket/mod.rs(Replace socket FFI with libc versions #746, Fixstruct msghdrtypes on non-Linux platforms. #648)src/sys/memfd.rs(Migrate memfd constants to libc #794)src/fcntl.rs(see Use upstream libc definitions for fcntl FFI #745)src/sched.rs(see Use libc types for sched and syscall FFI #747)src/sys/quota.rs(see Migrate quota module to libc FFI types #750)src/sys/ptrace.rs(see Moved ptrace constants into enum types plus minor additions #749)src/sys/syscall.rs(see Use libc types for sched and syscall FFI #747)src/errno.rs(see More libc ffi #798, Fix nix for Dragonfly #684, Switch to libc definitons of errno constants #807)The text was updated successfully, but these errors were encountered: