Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream libc definitions for fcntl FFI #745

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Use upstream libc definitions for fcntl FFI #745

merged 1 commit into from
Aug 30, 2017

Conversation

Susurrus
Copy link
Contributor

No description provided.

@Susurrus Susurrus force-pushed the fcntl branch 3 times, most recently from 3444d07 to ba73a9b Compare August 26, 2017 16:38
@Susurrus Susurrus mentioned this pull request Aug 26, 2017
Closed
8 tasks
@Susurrus Susurrus requested a review from asomers August 29, 2017 05:13
@Susurrus
Copy link
Contributor Author

The modification to the test is because O_LARGEFILES is 0 on some systems, which breaks from_bits. Instead we use from_bits_truncate to properly ignore that bitfields on the necessary systems. I think this should be good to merge.

asomers
asomers reviewed Aug 30, 2017
View reviewed changes
src/unistd.rs Outdated
@@ -2,7 +2,7 @@

use errno;
use {Errno, Error, Result, NixPath};
use fcntl::{fcntl, OFlag, O_CLOEXEC, FD_CLOEXEC};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move these use statements?

@Susurrus
Copy link
Contributor Author

@asomers Fixed.

@asomers
Copy link
Member

asomers commented Aug 30, 2017

bors r+

bors bot added a commit that referenced this pull request Aug 30, 2017
@bors
Merge #745
347e909 
745: Use upstream libc definitions for fcntl FFI r=asomers a=Susurrus
@bors
Copy link
Contributor

bors bot commented Aug 30, 2017

Build succeeded

@bors bors bot merged commit 2d4b137 into nix-rust:master Aug 30, 2017
@Susurrus Susurrus deleted the fcntl branch August 30, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Susurrus @asomers