Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct definition of MADV_SOFT_OFFLINE on ppc #1566

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Correct definition of MADV_SOFT_OFFLINE on ppc #1566

merged 1 commit into from
Oct 23, 2021

Conversation

asomers
Copy link
Member

@asomers asomers commented Oct 16, 2021

Rust has no "ppc" target_arch. It should be "powerpc" or "powerpc64".

Rust has no "ppc" target_arch.  It should be "powerpc" or "powerpc64".
@asomers
Copy link
Member Author

asomers commented Oct 16, 2021

This should be merged_after_ #1498 or bad merge collisions will result.

@asomers asomers added this to the 0.23.1 milestone Oct 16, 2021
@rtzoeller
Copy link
Collaborator

@asomers is there a way we can lint for this kind of typo?

@asomers
Copy link
Member Author

asomers commented Oct 16, 2021

I'm surprised that existing tools didn't already catch it. Rustdoc clearly knows that ppc wasn't a valid target_os. Clippy could, and probably should, check for this. It's similar to rust-lang/rust-clippy#5506 . I'll open an issue over there, but I don't know Clippy well enough to implement it myself.

@asomers asomers marked this pull request as ready for review October 23, 2021 00:10
@asomers
Copy link
Member Author

asomers commented Oct 23, 2021

I decided that this really needs to go in before #1498. I'll just have to deal with the merge collision.

@asomers
Copy link
Member Author

asomers commented Oct 23, 2021

bors r+

@bors bors bot merged commit 57d4c86 into master Oct 23, 2021
@asomers asomers deleted the ppc branch August 12, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants