Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select.rs FdSet: method `contains' should not mutate anything #564

Merged
merged 1 commit into from
Apr 17, 2017
Merged

select.rs FdSet: method `contains' should not mutate anything #564

merged 1 commit into from
Apr 17, 2017

Conversation

diekmann
Copy link
Contributor

The method does not change anything, so I updated the type signature. Tests pass.

@Susurrus
Copy link
Contributor

Since this is a public type, I think a changelog entry is required here. Otherwise this looks correct to me.

@diekmann
Copy link
Contributor Author

Thx. updated.

@homu
Copy link
Contributor

homu commented Apr 15, 2017

☔ The latest upstream changes (presumably #536) made this pull request unmergeable. Please resolve the merge conflicts.

@posborne
Copy link
Member

@diekmann Please rebase and resolve the conflict. Change looks good to me.

@diekmann
Copy link
Contributor Author

Rebased and force pushed 🦄

@homu
Copy link
Contributor

homu commented Apr 16, 2017

☔ The latest upstream changes (presumably 2f780ef) made this pull request unmergeable. Please resolve the merge conflicts.

@diekmann
Copy link
Contributor Author

resolved 🐰

@Susurrus
Copy link
Contributor

bors r=posborne

bors bot added a commit that referenced this pull request Apr 17, 2017
564: select.rs FdSet: method `contains' should not mutate anything r=posborne
The method does not change anything, so I updated the type signature. Tests pass.
@bors
Copy link
Contributor

bors bot commented Apr 17, 2017

Build succeeded

@bors bors bot merged commit e568ad9 into nix-rust:master Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants