Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include LICENSE to nix-test #808

Closed

Conversation

ignatenkobrain
Copy link
Contributor

Signed-off-by: Igor Gnatenko i.gnatenko.brain@gmail.com

Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
@asomers
Copy link
Member

asomers commented Dec 3, 2017

I don't understand. What is the purpose of this commit? What cares about that file?

@ignatenkobrain
Copy link
Contributor Author

@asomers nix-test is dependency of nix (dev one) hence it is published on crates.io. And MIT license requires text license to be present along with source. So if you download .crate from crates.io for nix-test it doesn't have license text which is violating license terms.

Thanks for understanding.

@Susurrus
Copy link
Contributor

Susurrus commented Dec 3, 2017

@ignatenkobrain Actually nix-test isn't regularly published to crates.io. I see there's a version up there, but it should actually be removed.

@ignatenkobrain
Copy link
Contributor Author

@Susurrus I don't think that crates with missing dependencies can be published on crates.io

@Susurrus
Copy link
Contributor

Susurrus commented Dec 3, 2017

I'm pretty certain we don't need this dependency published on crates.io. Therefore instead of updating this, we should actually pull that project.

@Susurrus
Copy link
Contributor

Susurrus commented Dec 3, 2017

@ignatenkobrain Thanks for bringing this to our attention, but rather than accept this patch, I'm going to close this in favor of #807, which will be removing this crate in its entirety as there will be no more reason for its existance once that's merged. I've also contacted Carl Lerche via email about pulling all versions of that crate and removing the project in its entirety.

@Susurrus Susurrus closed this Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants