Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix 2.20 stops working with git lfs #10079

Open
ktrinh-anduril opened this issue Feb 25, 2024 · 1 comment
Open

Nix 2.20 stops working with git lfs #10079

ktrinh-anduril opened this issue Feb 25, 2024 · 1 comment
Labels
bug fetching Networking with the outside (non-Nix) world idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome.

Comments

@ktrinh-anduril
Copy link

Describe the bug
Since Nix release of 2.20, git lfs has stopped working. At least from other tickets, it looks like more functionalities have been moved to libgit which doesn't support git lfs so that might make sense

Steps To Reproduce

  1. Have the lines below in git config along with git lfs installed:
[filter "lfs"]
	clean = git-lfs clean -- %f
	smudge = git-lfs smudge -- %f
	process = git-lfs filter-process
	required = true
  1. Run this in nix repl:
builtins.fetchGit {                  
  url = "https://huggingface.co/openlm-research/open_llama_3b";                                                                                                                     
  rev = "141067009124b9c0aea62c76b3eb952174864057";            
};

Expected it to fetch the LFS files like it did in 2.19 but it skipped them

@thufschmitt thufschmitt added the idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. label Feb 26, 2024
@thufschmitt
Copy link
Member

Discussed during the Nix maintainers meeting on 2024-02-26.
We won't implement it ourselves, but this is open to contributions.

  • A proper LFS implementation was previously blocked on the libgit2 rewrite
    • libgit2 with smudging support can be used to shell out of git-lfs
    • Maybe someday we make/use a library-level implementation, but let's not start with that unless its surprisingly easy
      • Might look like the submodule support
      • We have some gitattributes infrastructure

@roberth roberth added the fetching Networking with the outside (non-Nix) world label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fetching Networking with the outside (non-Nix) world idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome.
Projects
None yet
Development

No branches or pull requests

3 participants