Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PosixSourceAccessor to OsSourceAccessor #10557

Open
Ericson2314 opened this issue Apr 18, 2024 · 3 comments
Open

Rename PosixSourceAccessor to OsSourceAccessor #10557

Ericson2314 opened this issue Apr 18, 2024 · 3 comments
Labels

Comments

@Ericson2314
Copy link
Member

The name is confusing because it works on Windows too, as is the intention.

@roberth
Copy link
Member

roberth commented Apr 19, 2024

I would expect a subtype relation here.

PosixSourceAccessor could be the implementation of a NativeSourceAccessor interface, and almost all code would refer to NativeSourceAccessor, except perhaps code like the Linux-specific sandbox implementation, which might benefit from interacting with the more specific type.

@Ericson2314
Copy link
Member Author

That could be a thing, but so far this is no need for the PosixSourceAccessor subtype! The SourceAccessor interface is the restricted file system object model, and that is valid on both platforms.

@Ericson2314 Ericson2314 changed the title Rename PosixSourceAccessor to NativeSourceAccessor Rename PosixSourceAccessor to OsSourceAccessor Aug 5, 2024
@Ericson2314
Copy link
Member Author

Per #11178 (comment) thread and @roberth's and @L-as's suggestions, let's do Os not Native for these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants