Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladspa-sdk & ladspah: 1.13 ->1.15 #65143

Merged
merged 2 commits into from
Jul 27, 2019
Merged

ladspa-sdk & ladspah: 1.13 ->1.15 #65143

merged 2 commits into from
Jul 27, 2019

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jul 20, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you split this into two commits?
ladspa-sdk: 1.13 -> 1.15
ladspa: 1.13 -> 1.15

@magnetophon
Copy link
Member Author

@worldofpeace OK, done.

@worldofpeace worldofpeace merged commit 5f49ef3 into NixOS:master Jul 27, 2019
@magnetophon magnetophon deleted the ladspa-sdk branch July 27, 2019 18:34
@magnetophon magnetophon restored the ladspa-sdk branch July 27, 2019 18:34
@magnetophon magnetophon deleted the ladspa-sdk branch July 27, 2019 18:44
@delroth delroth mentioned this pull request Sep 14, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @worldofpeace