Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always evaluate with config.allowAliases = false to avoid deprecation warning errors #575

Closed
roberth opened this issue Aug 15, 2021 · 2 comments · Fixed by #645
Closed

Comments

@roberth
Copy link
Member

roberth commented Aug 15, 2021

Since #250, we've been checking that Nixpkgs doesn't depend on aliases.

In NixOS/nixpkgs#134230 I've had to revert deprecation warnings in order to let ofborg evaluate cleanly.

If we apply allowAliases = false to all evaluations, we will be able to provide helpful deprecation warnings without causing ofborg to fail.

It will also save an evaluation, because the separate check from #250 will be implicit in the other evals.

@roberth roberth changed the title Always evaluated with config.allowAliases = false to allow deprecation warnings Always evaluate with config.allowAliases = false to allow deprecation warnings Aug 15, 2021
@SuperSandro2000
Copy link
Member

Bump.
This is annoying for nixpkgs-review users because ofborg lists aliases in ^.^! which don't work if you have aliases locally disabled and break the tool.

@Artturin
Copy link
Member

Artturin commented Apr 1, 2022

i had to nixpkgs-review pr 166605 --eval local
otherwise i got this error

130 artturin@nixos ~ % review 166605
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs staging:refs/nixpkgs-review/0 pull/166605/head:refs/nixpkgs-review/1
$ git worktree add /home/artturin/.cache/nixpkgs-review/pr-166605-3/nixpkgs 8459123046dbdb9f03145310c5e36ce6195a7151
Preparing worktree (detached HEAD 8459123046d)
Updating files: 100% (30114/30114), done.
HEAD is now at 8459123046d Merge pull request #166715 from siraben/social-auth-eval-fix
$ git merge --no-commit --no-ff 4f2f6cb71e171016cea0f86f4ed6f36976fb4406
Automatic merge went well; stopped before committing as requested
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/artturin/.cache/nixpkgs-review/pr-166605-3/build.nix
error: attribute 'python_rsvg' missing

       at /home/artturin/.cache/nixpkgs-review/pr-166605-3/build.nix:3567:9:

         3566|         gnome2."gnome_python"
         3567|         gnome2."python_rsvg"
             |         ^
         3568|         gnome2."gnome_vfs"
(use '--show-trace' to show detailed location information)

created
NixOS/nixpkgs#166790

@roberth roberth changed the title Always evaluate with config.allowAliases = false to allow deprecation warnings Always evaluate with config.allowAliases = false to avoid deprecation warning errors Apr 1, 2022
Artturin added a commit to Artturin/ofborg that referenced this issue Apr 1, 2022
remove package-list-no-aliases
this will also save us an eval

Closes NixOS#575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants