Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runCommandNoCC: fix ofborg status #134230

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

roberth
Copy link
Member

@roberth roberth commented Aug 15, 2021

The original pr was merged a bit too soon.

Removing the deprecation warning shouldn't be necessary, but for
now, we need to prioritize making ofborg green.

A proper fix consists of something like d6aafb3 but in ofborg's code.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The original pr was merged a bit too soon.

Removing the deprecation warning shouldn't be necessary, but for
now, we need to prioritize making ofborg green.
@roberth
Copy link
Member Author

roberth commented Aug 15, 2021

It doesn't like that the status quo "does not evaluate cleanly" so I'll merge this without proper confirmation. This is a known issue with ofborg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant