-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GitHub notify when an eval error has occoured? #652
Comments
You do get a red X in the https://github.com/pulls view when CI fails. Sending messages every time eval fails would cause a storm everytime master fails eval. |
Correct, but I don't think it is bad. Eval errors on |
@pbsds this seems worth checking, but I don't understand how did you get to that interface? I also wonder, why is EditorConfig's workflow notifying me upon emails and ofborg doesn't? The interface you screenshot doesn't look like it has different settings for the above 2 workflows... |
It may be because the editor config checks run in a github action runner, while the ofborg CI checkmarks are set using some other API by the ofborg runners. |
Rather often, when you rename a package attribute or alike, another package you were not aware of has used the attribute name you deleted, and you forgot to change it accordingly.
It'd be nice if ofborg had sent via GitHub an email notifying of the eval failure - just like the EditorConfig job for example. This is helpful in slow evaluation which happen in e.g
treewide:
like PRs.The text was updated successfully, but these errors were encountered: