Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: use getpagesize() #41

Closed
Sierra-Sam opened this issue Oct 27, 2014 · 2 comments
Closed

Suggestion: use getpagesize() #41

Sierra-Sam opened this issue Oct 27, 2014 · 2 comments

Comments

@Sierra-Sam
Copy link

patchelf.cc has hard-coded values for pageSize.
I believe it would be more portable if PageSize were
discovered using the getpagesize() function.

Also, when I do code that involves size of any kind,
including page size, I use type, size_t. But, in this
case no one would care. Besides, getpagesize()
returns an int, but that is only because it is old.

@darealshinji
Copy link
Contributor

I guess this can be closed because of 35ecfa7

@fsateler
Copy link
Contributor

Even more now that #73 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants