Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds exclude_directories input #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexmigf
Copy link
Contributor

Currently there is not way to exclude specific directories from minification. This PR addresses this issue by adding a new input called exclude_directories which is relative to the directory input. If using more than 1 directory, they should be separated by semicolon.

Example using 1 directory

- name: Auto Minify
        uses: alexmigf/auto-minify@exclude-dirs
        with:
          directory: 'assets'
          exclude_directories: 'js/pdf_js'

Example using 2 directories

- name: Auto Minify
        uses: alexmigf/auto-minify@exclude-dirs
        with:
          directory: 'assets'
          exclude_directories: 'js/pdf_js;js/test'

@nizarmah nizarmah self-requested a review December 17, 2021 18:03
@nizarmah
Copy link
Owner

nizarmah commented Mar 7, 2024

Hello @alexmigf. I'm sorry for never responding to your pull request.

Thank you for putting the effort into adding this feature and documenting it.

I'll review this in the next 48 hours.

Copy link
Owner

@nizarmah nizarmah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight modification please

Comment on lines +11 to +14
exclude_directories:
description: "Exclude child folders from the main directory. Combine them in a string separated by semicolon and relative to the main directory eg. 'dir1;js/dir2;js/test/dir3'"
required: false
default: ""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alexmigf!

Can you switch this please to use line breaks?

Here's an example from StackOverflow.
https://stackoverflow.com/a/75420778/5512292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants