Added favicon to the debugger to fix problems with Google Chrome

njl · Feb 22, 2012 · 00c65aa · 00c65aa
1 parent 990bf00
commit 00c65aa
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,6 +1,18 @@
 Werkzeug Changelog
 ==================
 
+Version 0.8.4
+-------------
+
+(bugfix release, release date to be announced)
+
+- Added a favicon to the debugger which fixes problem with
+  state changes being triggered through a request to
+  /favicon.ico in Google Chrome.  This should fix some
+  problems with Flask and other frameworks that use
+  context local objects on a stack with context preservation
+  on errors.
+
 Version 0.8.3
 -------------
 

diff --git a/werkzeug/debug/tbtools.py b/werkzeug/debug/tbtools.py
@@ -37,6 +37,10 @@
   <head>
     <title>%(title)s // Werkzeug Debugger</title>
     <link rel="stylesheet" href="?__debugger__=yes&amp;cmd=resource&amp;f=style.css" type="text/css">
+    <!-- We need to make sure this has a favicon so that the debugger does not by
+         accident trigger a request to /favicon.ico which might change the application
+         state. -->
+    <link rel="shortcut icon" href="?__debugger__=yes&amp;cmd=resource&amp;f=console.png">
     <script type="text/javascript" src="?__debugger__=yes&amp;cmd=resource&amp;f=jquery.js"></script>
     <script type="text/javascript" src="?__debugger__=yes&amp;cmd=resource&amp;f=debugger.js"></script>
     <script type="text/javascript">