Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed using $caller::VariableName - #33

Merged
merged 3 commits into from
Aug 2, 2016
Merged

fixed using $caller::VariableName - #33

merged 3 commits into from
Aug 2, 2016

Conversation

ufobat
Copy link
Contributor

@ufobat ufobat commented Aug 2, 2016

now using namespace in $caller then namespace "caller"

@njlg
Copy link
Owner

njlg commented Aug 2, 2016

There appears to be some errors with that change. See the logs from the Travis-CI builds.

@ufobat
Copy link
Contributor Author

ufobat commented Aug 2, 2016

sorry :-( should be fixed now

@coveralls
Copy link

coveralls commented Aug 2, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 96.091% when pulling f5eeaf8 on ufobat:caller into 1ed1063 on njlg:master.

@njlg
Copy link
Owner

njlg commented Aug 2, 2016

This looks good. I only have a minor quip: I prefer single quotes unless interpolation is required.

@njlg njlg merged commit c1734e9 into njlg:master Aug 2, 2016
@njlg
Copy link
Owner

njlg commented Aug 2, 2016

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ufobat @njlg @coveralls