-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read THERMR::Card2::natom parameter from file instead of from user input #110
Comments
@kahlerac Has the |
This is the same as the first point in #80 |
natom is not defined in legacy (ENDF/B-III) files but B(1) which is sig(el)*natom is present which is why natom is a user input |
So if we just check the ENDF version and if it is greater than 3 then we can ignore the |
e3 was carried forward to e4, e5 and first couple of e6 releases. natom
definition appeared when MacFarlane updated the thermal files in e63
(although his report says e62 since that was the release he hoped to have
things done by).
Skip
…On Mon, Nov 5, 2018, 5:09 PM Jeremy Lloyd Conlin ***@***.*** wrote:
So if we just check the ENDF version and if it is greater than 3 then we
can ignore the natom value, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#110 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQ6UScyihWP4GnMewf_SV26dHByrHqPEks5usLcQgaJpZM4YPQ0o>
.
|
And now we begin to see why this hasn't been taken out previously—it isn't backwards compatible. What was B(6) before it was defined to be |
I believe B(6) is unused ( and therefore set to zero) in e3. That's what's
in the e3 h-h2o file but I'd have to check an old manual to be sure.
Skip
…On Mon, Nov 5, 2018, 6:04 PM Jeremy Lloyd Conlin ***@***.*** wrote:
And now we begin to see why this hasn't been taken out previously—it isn't
backwards compatible.
What was B(6) before it was defined to be natom? If it was always 0, then
we can check against that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#110 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQ6USYDSGt3Gmk-XPPSHJl7EG5KtUFmgks5usMPggaJpZM4YPQ0o>
.
|
The
natom
parameter in Card2 of THERMR is present on the evaluation file. It should be read from the evaluation file instead of taken from the user. This should be an easy thing to fix.The text was updated successfully, but these errors were encountered: