Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read THERMR::Card2::natom parameter from file instead of from user input #110

Open
jlconlin opened this issue Nov 5, 2018 · 7 comments
Open
Assignees

Comments

@jlconlin
Copy link
Member

jlconlin commented Nov 5, 2018

The natom parameter in Card2 of THERMR is present on the evaluation file. It should be read from the evaluation file instead of taken from the user. This should be an easy thing to fix.

@jlconlin
Copy link
Member Author

jlconlin commented Nov 5, 2018

@kahlerac Has the natom always been in ENDF? That is, do evaluations before ENDF/B-VI have that parameter in it? If so, we should check the format number to determine if we can ignore the user input or not.

@jlconlin
Copy link
Member Author

jlconlin commented Nov 5, 2018

This is the same as the first point in #80

@kahlerac
Copy link
Contributor

kahlerac commented Nov 5, 2018

natom is not defined in legacy (ENDF/B-III) files but B(1) which is sig(el)*natom is present which is why natom is a user input

@jlconlin
Copy link
Member Author

jlconlin commented Nov 5, 2018

So if we just check the ENDF version and if it is greater than 3 then we can ignore the natom value, right?

@kahlerac
Copy link
Contributor

kahlerac commented Nov 5, 2018 via email

@jlconlin
Copy link
Member Author

jlconlin commented Nov 5, 2018

And now we begin to see why this hasn't been taken out previously—it isn't backwards compatible.

What was B(6) before it was defined to be natom? If it was always 0, then we can check against that.

@kahlerac
Copy link
Contributor

kahlerac commented Nov 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants