Feature/acer #10
Closed
Feature/acer #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python ify
…referencing in cmake script
preparing for subtree conversion
Now just need to add a few tests to make it fail.
|
Very impressive pull request. I'll be putting 90 minutes/day towards this review. |
It was accidentally added.
|
These changes are redundant with the GROUPR pull. Closing pending objections otherwise |
apmccartney
reviewed
Jul 4, 2017
src/njoy21/input/ACER/Card2/Iopt.hpp
Outdated
| " 4: photo-atomic data\n" | ||
| " 5: photo-nuclear data\n" | ||
| " 7: read type 1 ace files to print or edit\n" | ||
| " 8: read type 2 ace files to print or edit\n"; |
| "The default value of 1 produces a complete, interpreted listing of\n" | ||
| "the ACE dataa. The whorter prit options (value 0) just put out \n" | ||
| "progress information from the ACER job and a brief listing of the \n" | ||
| "header information for the library that was generated."; |
| "boolean switch to turn off (or on) the output.\n" | ||
| "\n" | ||
| "The default value of 1 produces a complete, interpreted listing of\n" | ||
| "the ACE dataa. The whorter prit options (value 0) just put out \n" |
| @@ -0,0 +1,17 @@ | |||
| struct Suff { | |||
| using Value_t = double; | |||
There was a problem hiding this comment.
double probably not appropriate
|
|
||
| static std::string description(){ | ||
| return | ||
| "The tempd argument specifies the absolute temperature for the \n" |
There was a problem hiding this comment.
units (some weirdos use MeV for temperature)
| "The thin2 argument specifies the energy above which to use all\n" | ||
| "energies (eV)---i.e., no thinning above this energy.\n"; | ||
| } | ||
| static Value_t defaultValue(){ return 0.0; } |
| "energies (eV)---i.e., no thinning above this energy.\n"; | ||
| } | ||
| static Value_t defaultValue(){ return 0.0; } | ||
| static bool verify( const Value_t& e2 ){ return e2 >= 0.0; } |
| @@ -0,0 +1,12 @@ | |||
| struct Thin2 { | |||
| using Value_t = double; | |||
| @@ -0,0 +1,20 @@ | |||
| struct Thin1 { | |||
| using Value_t = double; | |||
| "\n" | ||
| "When thin1=2, the 1/E weighting has a weighting of 10 when E < 0.1."; | ||
| } | ||
| static Value_t defaultValue(){ return 0.0; } |
|
Just realized my comments weren't submitted. Ugh |
jlconlin
added a commit
that referenced
this pull request
Oct 1, 2018
1fadec59 Adding ability to generate a signature. d6993d89 Making signature compatible with Python3 900549fd Merge pull request #15 from njoy/feature/python3_to_python a348df3e Merge pull request #16 from njoy/feature/WindowsyLinux 24cd40e4 Added subobject linkage error exception in common flags. b3d69551 Merged. f22bae27 Adding Windows options for Cygwin and MinGW. 41786f56 Added check in CMakeLists.txt generated by cmake.py for python version. e72a44f8 Added version check of Git in constructed CMakeLists.txt. 07488448 Windows/Cygwin testing. 597ff743 Changing python3 to python. ca6c3089 Added MinGW and CYGWIN environments to metaconfigure. ff293c6d Update cmake.py 6bda6e9b Update configuration.py 69647abe Update cmake.py 730615a3 Update index.md d584ae26 Merge pull request #10 from njoy/docs 8582ee24 Beginning of metaconfigure documentation. 10fad1fb Add 'docs/' from commit '9a9fd02407b5cedbb0d1dd837143187e96dbdea8' 3f39eb5f Merge pull request #9 from njoy/README 7f027c04 Fixing issue related to Python3. 3aa95530 strictness project specific a7c72a96 Updating README following pull request comments. 4b4f943b Clarifying need for include path. 156cb72f Being more specific 2e5a0a7f Finished with updating commands. 47cd119f Working on README. 1dce0f6e Adding README file. 9a9fd02 Adding some information about not pushing to this remote. 7e673cc Fixing markup typo. 75d2869 Adding LA-CC to footer. c3e5e2e Fixing where the header href points to. 6d7eeee Removing base-url from navigation href. 332563f Updating navigation links. e6a92f3 Moving where description is derived. 1ed4817 Fixing link to LICENSE file. 11d8cfb Making some changes to the look. f46cfc3 Updating config to [in/ex]clude some files. 0d23c3c Making link to license file in footer. a048936 Updating URL to Developer's Guide. 169ecf5 Removing projects.yml from this repository. a7dbded Changing location of DevelopersGuide. 52c6579 Adding data for NJOY projects. 15c529c Renaming README so it doesn't conflict. 06e582b Adding Gemfile. 2eb701e Adding all the basic Jekyll stuff. 13d0fbb Initial commit git-subtree-dir: metaconfigure git-subtree-split: 1fadec594f62735a5faad55792a133c6185ac36f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need some tests to make the ACER input checking fail.