Merge pull request urllib3#13 from pquentin/recent-date-fix

Fix RECENT_DATE
njsmith · Mar 17, 2018 · 93e21af · 93e21af
2 parents aa3ccef + 8b78982
commit 93e21af
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/test/test_connection.py b/test/test_connection.py
@@ -43,7 +43,6 @@ def test_match_hostname_mismatch(self):
             )
             assert e._peer_cert == cert
 
-    @pytest.mark.xfail
     def test_recent_date(self):
         # This test is to make sure that the RECENT_DATE value
         # doesn't get too far behind what the current date is.

diff --git a/urllib3/_async/connection.py b/urllib3/_async/connection.py
@@ -38,10 +38,11 @@
     ssl = None
 
 
-# When updating RECENT_DATE, move it to
-# within two years of the current date, and no
-# earlier than 6 months ago.
-RECENT_DATE = datetime.date(2016, 1, 1)
+# When updating RECENT_DATE, move it to within two years of the current date,
+# and not less than 6 months ago.
+# Example: if Today is 2018-01-01, then RECENT_DATE should be any date on or
+# after 2016-01-01 (today - 2 years) AND before 2017-07-01 (today - 6 months)
+RECENT_DATE = datetime.date(2017, 6, 30)
 
 _SUPPORTED_VERSIONS = frozenset([b'1.0', b'1.1'])