miss_case_table and miss_var_table now has final column names `pc…

…t_vars`, and `pct_cases` instead of `pct_miss` - fixes #178. Also updated .svg tests using dev ggplot2
njtierney · Jun 20, 2018 · 7db68a0 · 7db68a0
1 parent 1a779f5
commit 7db68a0
Show file tree

Hide file tree

Showing 26 changed files with 3,143 additions and 3,136 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: naniar
 Type: Package
 Title: Data Structures, Summaries, and Visualisations for Missing Data
-Version: 0.3.1.9000
+Version: 0.3.1.9100
 Authors@R: c(
   person("Nicholas", "Tierney", 
          role = c("aut", "cre"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,10 @@
+# naniar 0.3.1.91000 (2018/06/10)
+
+## Minor Change
+
+- `miss_case_table` and `miss_var_table` now has final column names `pct_vars`,
+and `pct_cases` instead of `pct_miss` - fixes #178.
+
 # naniar 0.3.1 (2018/06/10) "Strawberry's Adventure"
 
 ## Minor Change

diff --git a/R/miss-x-table.R b/R/miss-x-table.R
@@ -37,7 +37,7 @@ miss_case_table.default <- function(data){
   data %>%
     dplyr::group_by(n_miss_in_case) %>%
     dplyr::tally() %>%
-    dplyr::mutate(pct_miss = (n / nrow(data) * 100)) %>%
+    dplyr::mutate(pct_cases = (n / nrow(data) * 100)) %>%
     dplyr::rename(n_cases = n)
 
 }
@@ -93,7 +93,7 @@ miss_var_table.default <- function(data){
     dplyr::group_by(n_miss_in_var) %>%
     dplyr::tally() %>%
     dplyr::rename(n_vars = n) %>%
-    dplyr::mutate(pct_miss = (n_vars / ncol(data) * 100))
+    dplyr::mutate(pct_vars = (n_vars / ncol(data) * 100))
 
 }
 

diff --git a/man/naniar-ggproto.Rd b/man/naniar-ggproto.Rd
diff --git a/tests/figs/deps.txt b/tests/figs/deps.txt
@@ -3,4 +3,4 @@ FreeType: 2.7.0
 Cairo: 1.14.6
 vdiffr: 0.2.3
 svglite: 1.2.1
-ggplot2: 2.2.1
+ggplot2: 2.2.1.9000
diff --git a/tests/figs/geom-miss-point/geom-miss-point.svg b/tests/figs/geom-miss-point/geom-miss-point.svg
diff --git a/tests/figs/gg-miss-case-cumsum/gg-miss-case-cumsum.svg b/tests/figs/gg-miss-case-cumsum/gg-miss-case-cumsum.svg
diff --git a/tests/figs/gg-miss-case/gg-miss-case-group-and-sort-show-pct.svg b/tests/figs/gg-miss-case/gg-miss-case-group-and-sort-show-pct.svg
diff --git a/tests/figs/gg-miss-case/gg-miss-case-group-and-sort.svg b/tests/figs/gg-miss-case/gg-miss-case-group-and-sort.svg
diff --git a/tests/figs/gg-miss-case/gg-miss-case-group-show-pct.svg b/tests/figs/gg-miss-case/gg-miss-case-group-show-pct.svg
diff --git a/tests/figs/gg-miss-case/gg-miss-case-group.svg b/tests/figs/gg-miss-case/gg-miss-case-group.svg
diff --git a/tests/figs/gg-miss-case/gg-miss-case-plot-show-pct.svg b/tests/figs/gg-miss-case/gg-miss-case-plot-show-pct.svg
diff --git a/tests/figs/gg-miss-case/gg-miss-case-sort-show-pct.svg b/tests/figs/gg-miss-case/gg-miss-case-sort-show-pct.svg
diff --git a/tests/figs/gg-miss-case/gg-miss-case-sort.svg b/tests/figs/gg-miss-case/gg-miss-case-sort.svg
diff --git a/tests/figs/gg-miss-case/gg-miss-case.svg b/tests/figs/gg-miss-case/gg-miss-case.svg
diff --git a/tests/figs/gg-miss-fct/gg-miss-fct.svg b/tests/figs/gg-miss-fct/gg-miss-fct.svg
diff --git a/tests/figs/gg-miss-span/gg-miss-span-group.svg b/tests/figs/gg-miss-span/gg-miss-span-group.svg
diff --git a/tests/figs/gg-miss-span/gg-miss-span.svg b/tests/figs/gg-miss-span/gg-miss-span.svg
diff --git a/tests/figs/gg-miss-var-cumsum/gg-miss-var-cumsum.svg b/tests/figs/gg-miss-var-cumsum/gg-miss-var-cumsum.svg