Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miss_var_table and miss_case_table should display pct_var and pct_case instead of pct_miss #178

Closed
njtierney opened this Issue Jun 20, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@njtierney
Copy link
Owner

njtierney commented Jun 20, 2018

For example:

miss_var_table(airquality)
# A tibble: 3 x 3
  n_miss_in_var n_vars pct_miss
          <int>  <int>    <dbl>
1             0      4     66.7
2             7      1     16.7
3            37      1     16.7
miss_case_table(airquality)
# A tibble: 3 x 3
  n_miss_in_case n_cases pct_miss
           <int>   <int>    <dbl>
1              0     111    72.5 
2              1      40    26.1 
3              2       2     1.31

It is not accurate to say that when there are 0 missings in variables, 66.7% of variables have this, but rather that variables with 66.7% missing - rather that 66.7% of variables/cases have this. So the output should be:

miss_var_table(airquality)
# A tibble: 3 x 3
  n_miss_in_var n_vars pct_vars
          <int>  <int>    <dbl>
1             0      4     66.7
2             7      1     16.7
3            37      1     16.7
miss_case_table(airquality)
# A tibble: 3 x 3
  n_miss_in_case n_cases pct_cases
           <int>   <int>    <dbl>
1              0     111    72.5 
2              1      40    26.1 
3              2       2     1.31

@njtierney njtierney added this to the V0.4.0 milestone Jun 20, 2018

njtierney added a commit that referenced this issue Jun 20, 2018

`miss_case_table` and `miss_var_table` now has final column names `pc…
…t_vars`,

and `pct_cases` instead of `pct_miss` - fixes #178. Also updated .svg tests using dev ggplot2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.