Expand usages of #hash_on. The #hash definition it produces looks bro…

…ken, but leaving it for now
nkallen · May 18, 2009 · 65e419c · 65e419c
1 parent 930c9f9
commit 65e419c
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 14 deletions.
diff --git a/lib/arel/algebra/extensions/class.rb b/lib/arel/algebra/extensions/class.rb
@@ -25,16 +25,6 @@ def ==(other)
       }
       class_eval methods[method_name], __FILE__, __LINE__
     end
-
-    def hash_on(delegatee)
-      define_method :eql? do |other|
-        self == other
-      end
-
-      define_method :hash do
-        @hash ||= delegatee.hash
-      end
-    end
 
     Class.send(:include, self)
   end

diff --git a/lib/arel/algebra/relations/operations/join.rb b/lib/arel/algebra/relations/operations/join.rb
@@ -3,12 +3,19 @@ class Join < Relation
     attributes :relation1, :relation2, :predicates
     deriving :==
     delegate :name, :to => :relation1
-    hash_on :relation1
 
     def initialize(relation1, relation2 = Nil.instance, *predicates)
       @relation1, @relation2, @predicates = relation1, relation2, predicates
     end
 
+    def hash
+      @hash ||= :relation1.hash
+    end
+
+    def eql?(other)
+      self == other
+    end
+
     def attributes
       @attributes ||= (relation1.externalize.attributes +
         relation2.externalize.attributes).collect { |a| a.bind(self) }

diff --git a/lib/arel/algebra/relations/utilities/compound.rb b/lib/arel/algebra/relations/utilities/compound.rb
@@ -1,7 +1,6 @@
 module Arel
   class Compound < Relation
     attr_reader :relation
-    hash_on :relation
     delegate :joins, :join?, :inserts, :taken, :skipped, :name, :externalizable?,
              :column_for, :engine,
              :to => :relation
@@ -14,7 +13,16 @@ def #{operation_name}
       OPERATION
     end
 
-    private
+    def hash
+      @hash ||= :relation.hash
+    end
+
+    def eql?(other)
+      self == other
+    end
+
+  private
+
     def arguments_from_block(relation, &block)
       block_given?? [yield(relation)] : []
     end

diff --git a/lib/arel/engines/sql/relations/table.rb b/lib/arel/engines/sql/relations/table.rb
@@ -4,7 +4,6 @@ class Table < Relation
 
     cattr_accessor :engine
     attr_reader :name, :engine
-    hash_on :name
 
     def initialize(name, engine = Table.engine)
       @name, @engine = name.to_s, engine
@@ -16,6 +15,14 @@ def attributes
       end
     end
 
+    def eql?(other)
+      self == other
+    end
+
+    def hash
+      @hash ||= :name.hash
+    end
+
     def format(attribute, value)
       attribute.column.type_cast(value)
     end