Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about how to avoid margin "bug" #111

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

selbekk
Copy link

@selbekk selbekk commented Oct 4, 2016

Due to the complicated nature of how (vertical) margins work, it's very hard to calculate the height of an element including its margins.

Forgetting this will give you an annoying little "jump" in height as the expand-animation ends its course.

This PR simply mentions this in the readme, so I remember why next time.

Documents #101

@codecov-io
Copy link

Current coverage is 11.59% (diff: 100%)

Merging #111 into 2.x will not change coverage

@@                2.x       #111   diff @@
==========================================
  Files             1          1          
  Lines            69         69          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits              8          8          
  Misses           61         61          
  Partials          0          0          

Powered by Codecov. Last update 425a7fb...b1a3a57

@selbekk
Copy link
Author

selbekk commented Oct 4, 2016

I'd be more than happy to add some tests to your codebase as well, just let me know whenever you're starting to decide on the v3.0.0 API

@nkbt
Copy link
Owner

nkbt commented Oct 4, 2016

V3 is already there :). It is in master.

Thanks heaps!
On Tue., 4 Oct. 2016 at 18:16, Kristofer Selbekk notifications@github.com
wrote:

I'd be more than happy to add some tests to your codebase as well, just
let me know whenever you're starting to decide on the v3.0.0 API


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#111 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKsoBwi5xvDHLqSf3XbaK1aouJnwWIkks5qwf1fgaJpZM4KNW8D
.

Copy link
Owner

@nkbt nkbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I reckon we need it in master too :)

@nkbt nkbt merged commit aeb2424 into nkbt:2.x Oct 4, 2016
@selbekk selbekk deleted the 101-add-margin-bug-info-to-readme branch October 4, 2016 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants