Rewrite

[nkbt]

Well... hmmm... full rewrite

• get rid of defaultStyle actually need it for react-motion
• measure height before collapsing
• get rid of fixed height case
• fix examples to behave correctly
• get rid of keepCollapsedContent option, always keep instead
• Fixes Re-render nested components #40, Re-render nested components
• Fixes Animation finished callback #51, Animation finished callback
• Fixes instantly collapses if rerendered during collapse #59, instantly collapses if rerendered during collapse
• Fixes Unnecessary unmount with keepCollapsedContent #66, Unnecessary unmount with keepCollapsedContent
• Fixes Move react-height back to dependencies #53, Move react-height back to dependencies
• Fixes re-animation on re-render #31, re-animation on re-render
• Fixes Wrong height calculated in nested components #34, Wrong height calculated in nested components
• Fixes Add an option to avoid initial render of content #63, Add an option to avoid initial render of content
• Closes [WIP] Rewrite #71

[codecov-io]

Current coverage is 23.52% (diff: 19.14%)

Merging #72 into master will increase coverage by 11.93%

@@             master        #72   diff @@
==========================================
  Files             1          1          
  Lines            69         51    -18   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits              8         12     +4   
+ Misses           61         39    -22   
  Partials          0          0          

Powered by Codecov. Last update c52888b...7ae3da4

[sompylasar]

Might be better to call the callbacks without providing this context of this.props object, i.e.

const { onRest } = this.props;
onRest();  // no forced `this`

or

(0, this.props.onRest)();  // "global eval"

[nkbt]

Why so?

[sompylasar]

Because the callbacks are not methods of this.props object. I generally avoid calling such functions as methods because this changes semantics of what is expected inside these functions (I expect strictly no this inside).

[nkbt]

Good point, thanks

[nkbt]

Good idea, done. Also renamed to be more reasonable.

[nkbt]

Yay! Looks like all edge-cases from issues are covered now by examples!

[nkbt]

Since keepCollapsedContent is removed as well as fixedHeight, I need to add some examples or maybe couple of extra components that will wrap Collapse and implement same functionality

[nkbt]

I switched default branch to 2.x so README reflects currently published version and I can merge this to master without consequences.

[nkbt]

Published as react-collapse@3.0.0 or react-collapse@next. Not the main channel yet until better tested in the wild

[sompylasar]

In my current projects I have no need for Collapse yet, so I won't be able to test it "in the wild". I've reported to my teammates who needed it, maybe they will try it.

[sompylasar]

@nkbt Please could you add a brief migration guide from 2.x to 3.x to the readme? thanks!

[sompylasar]

@nkbt And the GIF in the readme looks like it's from the old implementation, as it mentions fixedHeight. Needs an update, too.

[sompylasar]

The Hooks example scrolls to the bottom of the page on page load when opening this page: http://nkbt.github.io/react-collapse/example/

[sompylasar]

Auto-scroll does not work properly:

0 paragraphs

---

3 paragraphs

[nkbt]

Yeah I definitely will add a migration guide. Scrolling is no longer in
hooks example, it is outdated. New examples do not have this
On Sun, 14 Aug 2016 at 05:45, John Babak notifications@github.com wrote:

Auto-scroll does not work properly:
0 paragraphs

[image: auto-scroll-hook-empty]

https://cloud.githubusercontent.com/assets/498274/17645206/7f8682c2-61a7-11e6-8da1-bba17f0bc481.gif

3 paragraphs

[image: auto-scroll-hook]
https://cloud.githubusercontent.com/assets/498274/17645208/83a3caae-61a7-11e6-929b-4e01298b15be.gif

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#72 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKsoLUUFxYPNS3F27fcsiLS_Unig0pLks5qfh7ggaJpZM4JiA0O
.

[sompylasar]

Yeah I definitely will add a migration guide.

Thanks!

Scrolling is no longer in hooks example, it is outdated. New examples do not have this

I for some reason thought that nkbt,github.io is linked to the new branch. OK.

[nkbt]

Not yet, until normal release. https://npmcdn.com/react-collapse@3.0.0/build/react-collapse.js -- I need to make a codepen with it for now (or maybe several)

[nkbt]

re-published newer version https://npmcdn.com/react-collapse@3.1.1/build/react-collapse.js

Probably better to use https://npmcdn.com/react-collapse@next/build/react-collapse.js