Migrated deprecated React.PropTypes and React.createClass #26
Conversation
| @@ -1,4 +1,5 @@ | |||
| import React from 'react'; | |||
| import createReactClass from 'create-react-class'; | |||
| import {shouldComponentUpdate} from 'react/lib/ReactComponentWithPureRenderMixin'; | |||
There was a problem hiding this comment.
FYI: react/lib/ReactComponentWithPureRenderMixin will remove in React v16
See also satya164/react-navigation-addons#5
There was a problem hiding this comment.
well, when we switch to es6 classes we just need to use PureComponent, so its easily fixable
There was a problem hiding this comment.
Just in case... If the only use of react-height for you is react-collapse - switch to react-collapse@3, that one does not have react-height dependency anymore.
There was a problem hiding this comment.
so this goal - "used as backend for react-collapse" should be removed?
also - what about merging this in? should something more be done here?
There was a problem hiding this comment.
I cannot see any deprecation notices about this. Which version of react we are talking here? 15.x still has it
There was a problem hiding this comment.
Deprecation on React v15.4.
However, there is a possibility that you imported private APIs from react/lib/*, or that a package you rely on might use them. We would like to remind you that this was never supported, and that your apps should not rely on internal APIs. The React internals will keep changing as we work to make React better.
-- React v15.4.0 - React Blog
I've test react-height on react v16.
npm i -D react@next
react/lib/ReactComponentWithPureRenderMixin has been removed.
Because, React v16 switch to flat bundles.
Switch to flat bundles (no more react-dom/lib/*, internals are truly private)
-- facebook/react#8854
There was a problem hiding this comment.
Yeah, that is cool. Won't mind a PR for this. Currently it does not produce any warnings.
There was a very practical reason to deeplink it.
React team did not create a standalone package for shallow compare so we could not make it external. If we used special package - it just required this deeplinked react/lib/ReactComponentWithPureRenderMixin. So when included in the bundle - well... You include half of React package with it. Not nice for a small library.
Bundle size should not be increased when we migrated to whatever other solution is there...
There was a problem hiding this comment.
I think PureComponent is exactly this - Component + PureRenderMixin
There was a problem hiding this comment.
Can only be used with ES6 Classes, not createReactClass factory =(
Need to update all the code to use Classes instead, to avoid extra dependency.
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
+ Coverage 19.23% 25% +5.76%
=======================================
Files 1 1
Lines 26 28 +2
=======================================
+ Hits 5 7 +2
Misses 21 21
Continue to review full report at Codecov.
|
|
Ye, sure. We'll try to help with that and do both at the same time
…On Tue, 18 Apr 2017 at 10:09, Nik Butenko ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/example/App/VariableText.js
<#26 (comment)>:
> @@ -1,4 +1,5 @@
import React from 'react';
+import createReactClass from 'create-react-class';
import {shouldComponentUpdate} from 'react/lib/ReactComponentWithPureRenderMixin';
Can only be used with ES6 Classes, not createReactClass factory =(
Need to update all the code to use Classes instead, to avoid extra
dependency.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJWMknrxhPs38RQjvCeZ9gs_qECq1-cDks5rxG-kgaJpZM4M3rQ_>
.
|
|
Thanks! 💯 |
I think we should migrate to the es6
classsyntax and stop usingReact.createClass, but that would be another step. For now just created this PR, so people stop having deprecation warnings after migration to React v15.5.If you feel the same about
class, I'll create an issue about it, so the matter won't get forgotten and neglected.