Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NKN node wss domain DNS service #1

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Add NKN node wss domain DNS service #1

merged 2 commits into from
Dec 10, 2019

Conversation

bufrr
Copy link

@bufrr bufrr commented Dec 6, 2019

No description provided.

yilunzhang
yilunzhang reviewed Dec 10, 2019
View reviewed changes
server/serve.go Outdated Show resolved Hide resolved
yilunzhang
yilunzhang reviewed Dec 10, 2019
View reviewed changes
server/serve.go Outdated Show resolved Hide resolved
yilunzhang
yilunzhang approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@yilunzhang yilunzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

gdmmx
gdmmx reviewed Dec 10, 2019
View reviewed changes
zones/reader.go Show resolved Hide resolved
@gdmmx gdmmx merged commit cf0b280 into nknorg:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yilunzhang yilunzhang yilunzhang approved these changes

@gdmmx gdmmx gdmmx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bufrr @yilunzhang @gdmmx