Return error when can't get conn to send ACK #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Always run |
yilunzhang
reviewed
Feb 20, 2023
src/session.js
Outdated
| @@ -219,6 +219,8 @@ export default class Session { | |||
| let conn = this.connections.get(util.connKey(localClientID, remoteClientID)); | |||
| if (conn) { | |||
| conn.sendAck(packet.getSequenceId()); | |||
| } else { | |||
| throw new errors.ConnNotFoundError(util.connKey(localClientID, remoteClientID)); | |||
There was a problem hiding this comment.
The error message here contains only connKey. It's better to be more verbose, like Conn xxx not found
|
You forgot |
Signed-off-by: bill fort <fxbao@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the reader gets packets and needs to send ACK back to the writer, if can't find the right connection, throw ConnNotFoundError.