Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLEEddystoneTLM.cpp doesn't compile without Arduino.h #447

Closed
thomasvdwege opened this issue Mar 22, 2018 · 2 comments
Closed

BLEEddystoneTLM.cpp doesn't compile without Arduino.h #447

thomasvdwege opened this issue Mar 22, 2018 · 2 comments
Assignees
Labels

Comments

@thomasvdwege
Copy link
Contributor

BLEEddystoneTLM.cpp doesn't compile when you don't have an Arduino environment on your pc. Could this be fixed? @pcbreflux made the file, I don't think the cpp-utils are supposed to break when you don't have Arduino installed.

For anyone encountering this issue, simply commenting the whole BLEEddystoneTLM.cpp file works.

@chegewara
Copy link
Collaborator

Or just deleting it

@nkolban
Copy link
Owner

nkolban commented Mar 29, 2018

I have pulled these files and moved them into the cpp_utils/onhold directory. Thank you mr @thomasvdwege for reporting and sorry for the issue. We should always have a clean build of cpp_utils without any trace of Arduino. I also didn't find any documentation in the source to explain these source files. I'm a huge fan of mr @pcbreflux work and I hope he will come back and clarify the files. If they are samples, then we can include them in some samples folder as opposed to being in the core build path of the BLE and cpp_utils library.

@nkolban nkolban self-assigned this Mar 29, 2018
@Donderda Donderda mentioned this issue Aug 7, 2018
@nkolban nkolban closed this as completed in 5f0a168 Aug 7, 2018
nkolban added a commit that referenced this issue Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants