fix: skip transform for vite-imagetools

[brenelz]

It seems to fix this specific issue. I'm just not 100% sure if it has any negative effects.

Seems to fix this issue: solidjs/solid-start#1195

Fix based on this pr: https://github.com/nuxt/framework/pull/9602/files

Before:

After:

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[changeset-bot]

⚠️ No Changeset found

Latest commit: 89d300b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vinxi-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 29, 2023 6:38pm

[nksaraf]

in that nuxt PR, it looks like they also a vite plugin that handles the skip_transform part. do we not need that as well? who receives this skip transform thing and what do they do with it?

[brenelz]

in that nuxt PR, it looks like they also a vite plugin that handles the skip_transform part. do we not need that as well? who receives this skip transform thing and what do they do with it?

Yeah I thought i would have to add more like that pr but this seems to fix it. Not sure if "_skip_transform" is a special property vite looks for maybe?

[brenelz]

Yeah I don't think this is quite right... it fixes it but no idea why. I can name the property anything

[nksaraf]

in that nuxt PR, it looks like they also a vite plugin that handles the skip_transform part. do we not need that as well? who receives this skip transform thing and what do they do with it?

Yeah I thought i would have to add more like that pr but this seems to fix it. Not sure if "_skip_transform" is a special property vite looks for maybe?

I looked for it in the vite repo and there was nothing there

[nksaraf]

And the nuxt fix is for this similar issue or something else?

[nksaraf]

I explored this more and found other things that cumulatively will solve this issue:

#72
#71
solidjs/solid-start#1198

In terms of usage, we will have to use the function form of the plugins options:

import { defineConfig } from "@solidjs/start/config";
import { imagetools } from "vite-imagetools";

export default defineConfig({
  plugins: () => [imagetools({})],
});