refactor: Reuse the the builder configuration in local mode #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nkz-soft 👋 I finally had some time to look into and test the pull request related to the Compose feature. While reviewing and testing the PR, I made some changes that I would like to discuss with you first:
DockerComposeContainer
implementation should be returned. I don't believe we needDockerCompose
and the proxy implementation. Additionally, to 2. this reduces the amount of necessary configurations.docker compose --file docker-compose.yml
, and use the command configuration for the actual compose command options, e.g.,up [OPTIONS]
. This has the advantage that developers can easily append options using theWithCommand(string)
API.RemoveImages
, unnecessary as well. We can implementWithRemoveImages(RemoveImages)
simply by:WDYT? Out of simplicity, I removed some parts related to the tests. I would like to discuss a few things first before we finalize the tests again.