Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtbook-to-html: better handling of pagebreaks between table rows #364

Closed
josteinaj opened this issue Jan 10, 2019 · 1 comment
Closed

dtbook-to-html: better handling of pagebreaks between table rows #364

josteinaj opened this issue Jan 10, 2019 · 1 comment

Comments

@josteinaj
Copy link
Member

Input DTBook:

<tr>
<td><p>…</p></td>
<td><p>…</p></td>
</tr>
<pagenum id="page-133" page="normal">133</pagenum>
<tr>
<td><p>…</p></td>
<td><p>…</p></td>
</tr>

Current XHTML output:

<tr>
<td><p>…</p></td>
<td><p>…</p></td>
</tr>
<tr>
<td><div id="page-133" class="page-normal" epub:type="pagebreak" title="133"></div><p>…</p></td>
<td><p>…</p></td>
</tr>

nordic-html5.rng gives an error about this: "element "p" not allowed here; expected the element end-tag". This is because pagebreaks are only allowed at the end of table cells.

The XHTML output should be:

<tr>
<td><p>…</p></td>
<td><p>…</p><div id="page-133" class="page-normal" epub:type="pagebreak" title="133"></div></td>
</tr>
<tr>
<td><p>…</p></td>
<td><p>…</p></td>
</tr>
josteinaj added a commit that referenced this issue May 13, 2019
josteinaj added a commit that referenced this issue May 13, 2019
see: #364

Also removed regression test added in previous commit as it is covered by other tests already.
@josteinaj josteinaj mentioned this issue May 14, 2019
@josteinaj
Copy link
Member Author

Fixed in v1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant