-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In admin select field selected choice displays as html #48
Comments
Hello @dbrabyn I'm not able to reproduce your bug. Do you have other plugins activated on your site? Maybe another plugin is loading a different version of select2. Try deactivating other plugins. |
I was just having the same issue. In my case, the culprit was WooCommerce. Toggling WooCommerce causes this issue to go away/come back. |
Yep, WooCommerce is loading plugins/woocommerce/assets/js/select2/select2.full.min.js?ver=4.0.3 which is really selectWoo, "a fork of select2 with improved accessibility". |
Having the same issue. |
A new version of ACF has been released:
Can you tell if that fixes the issue? |
I'm still seeing it with ACF Pro 5.10.1. |
Same here; still HTML in the dropdowns... |
Still there for me. |
Hi ACF-country users, I'm thinking about removing flags images in favor of emoji flags: lighter, removing a dependency, no more select2 issues, etc. What do you think about it? |
ACF 5.10.2 solved it for me. |
Hey there. Just found the same issue. The emoji flags idea looks great. Please let us know when we can test it. |
Looks like emoji flags are dead 😢 https://blog.unicode.org/2022/03/the-past-and-future-of-flag-emoji.html That's a shame and a bad coincidence, a few after days after I almost finished writing a new version with emoji flags... |
Ah dang, I was just coming to say I have the bug too (WP 6.0 / ACF 5.11 / WooCommerce 6.5.1), and that emojis was an awesome idea. Too bad :( |
@EmmanuelBeziat However, countries doesn't disappear or show up every morning (although the recent events may remind us that borders are not that set in stone 😞) I think I'll still push this new update soon. |
Changes: - Remove flag image usage in favor of emojis although they're pretty dead (see #48) - Use WordPress scripts to build assets instead of Laravel Mix - Bump ACF minimum version to ^6.0 - Bump PHP minimum version to ^7.4 || ^8.0 - Add .wp-env.json to ease local testing/dev
Changes: - Remove flag image usage in favor of emojis although they're pretty dead (see #48) - Use WordPress scripts to build assets instead of Laravel Mix - Bump ACF minimum version to ^6.0 - Bump PHP minimum version to ^7.4 || ^8.0 - Add .wp-env.json to ease local testing/dev - Make `get_countries` public
Finally got a project where I needed to use ACF Country so I decided to give it an update. You can try it here: https://github.com/nlemoine/acf-country/tree/3.x I finally went for using emojis flags although they're pretty dead but it provides the huge benefit of ending those Select2 issues. It's also lightweight and faster to show since you can display flags without the need to even use Select2. Note that it's ACF 6 compatible for now, at least if you use ACF UI. |
Details
Reproduction
Bug summary
In the admin the dropdown list displays the flag icons and country names correctly but the select field shows the following html for the flag icon and country name (in this case South Africa).
<span class="acf-country-flag-icon famfamfam-flags za"></span> <span class="acf-country-flag-name">Afrique du Sud</span>
Steps to reproduce
Regular WP install on local and production sites.
Actual result
See screen grab:
Expected result
In the admin the select field should display the flag icon and country name -- as it does for the dropdown list .
The text was updated successfully, but these errors were encountered: