Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Specify bounds for the to-be optimized ligand vector when computing cone angles #120

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Feb 15, 2022

The reduction in size of the optimization space seems to improve the final cone angles a bit.

@BvB93 BvB93 added the enhancement New feature or request label Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #120 (f4145e7) into master (9344186) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   53.80%   53.79%   -0.02%     
==========================================
  Files          36       36              
  Lines        2888     2887       -1     
==========================================
- Hits         1554     1553       -1     
  Misses       1334     1334              
Impacted Files Coverage Δ
nanoCAT/cone_angle.py 94.11% <100.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9344186...f4145e7. Read the comment docs.

@BvB93 BvB93 merged commit 488b608 into master Feb 15, 2022
@BvB93 BvB93 deleted the bounds branch February 15, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant