Make .foceiPreProcessData() work with tibbles #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There has been other issues I have seen with tibbles. My prior fix as to use as.data.frame just to ensure it works as expected. |
|
The other code should be ok. I think that things that arent purely data frames should be sanitized by this. Including tibbles, data.tables nlmixr fit, rxode solves etc |
|
That is the code you used that worked around the tibbles since it works for data frames too |
|
My fix in babelmixr2 will be to use as.data.frame(), but I thought while I'm at it, that making a fix for tibbles and then testing both could help. |
|
I believe that 'rxode2' should hit CRAN soon, so I will be pushing 'nlmixr2est' right after (as I promised the CRAN maintainers) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to nlmixr2/babelmixr2#52