-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Data cleaner and standardization functions #52
Comments
My overall thought is that there would likely be two functions: getStandardColumnNames <- function(data, cols) {
...
}
setStandardColumnNames <- function(data, cols) {
...
} Where if cols is missing, it gets all of the columns that nlmixr2 knows about with standardized names (e.g. "CMT" instead of "CmT", etc.). And the "set" version would do the renaming for standardized column names. If |
I think I am unsure what the value is above what is already provided in |
Moved issue from rxode2 to babelmixr2 |
@mattfidler, As I'm trying to implement this for the PKNCA linkage, I'm still wanting some of the original information that isn't present when doing the direct data conversion. As an example, if the user gives an ID column as "id", I'd like to know that and to be able to use that column for the subject identifier. The rationale is that I'd like to ensure that I can have a text subject identifier (e.g. "Study-001-Site-002-Subject-0003") instead of a cleaned, numeric ID. The PKNCA connection would still work to give initial estimates if I use the cleaned, numeric ID. But, if someone is wanting to track back to "why is this starting clearance 5 when I thought it would be 3", they would not have a link between the "ID" column that PKNCA used and the "ID" column that they originally gave. So, I think that column name mapping function would still be helpful. I'll make a first pass, and please let me know if it should do something else to improve it. |
I think it could be easy enough to use the |
I am still not clear what this provides. I am sure when you get to it I will understand 😄 |
😄 I just linked to the function I'm thinking of. The value for the PKNCA link is:
Overall, I'm wanting the NCA results to be interpretable so that when they're printed out, the user can have them available for comparison to the final modeled results. |
I have an issue with the "nlmixrRowNums" column where all rows are set to 1. I'm having trouble finding where it's set. Can you please help me find where it's set? |
Thanks. My issue was that my input was a tibble, so the length was 1. I made a PR to address that. |
This is handled now. |
I know that
nlmixr2
(and I think that it's mainly inrxode2
) does data cleaning before the model is sent to the integrator. I don't know where this is done, overall. And, I think that there would be additional needs withinnlmixr2est
. I think that it would be helpful to simplify, standardize, and centralize this data cleaning.Related to #45
The text was updated successfully, but these errors were encountered: