Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(lhs) not coded correctly for focei, but you can see it with nlmixr2 #21

Closed
mattfidler opened this issue Jan 21, 2022 · 2 comments · Fixed by #23
Closed

add(lhs) not coded correctly for focei, but you can see it with nlmixr2 #21

mattfidler opened this issue Jan 21, 2022 · 2 comments · Fixed by #23

Comments

@mattfidler
Copy link
Member

library(nlmixr2)
#> detected new version of nlmixr2, cleaning rxode2 cache

f <- function() {
  ini({
    tke <- 0.5
    eta.ke ~ 0.04
    prop.sd <- sqrt(0.1)
  })
  model({
    ke <- tke * exp(eta.ke)
    ipre <- 10 * exp(-ke * t)
    f2 <- ipre / (ipre + 5)
    f3 <- f2 * 3
    lipre <- log(ipre)
    ipre ~ prop(prop.sd)
  })
}

f %>%
  model(ipre ~ add(add.sd)) ->
  tmp1

tmp1$foceiModel0
#> rxModelVars({
#>     tke <- THETA[1]
#>     add.sd <- THETA[2]
#>     eta.ke <- ETA[1]
#>     ke <- tke * exp(eta.ke)
#>     ipre <- 10 * exp(-ke * t)
#>     f2 <- ipre/(ipre + 5)
#>     f3 <- f2 * 3
#>     lipre <- log(ipre)
#>     rx_yj_ ~ 2
#>     rx_lambda_ ~ 1
#>     rx_low_ ~ 0
#>     rx_hi_ ~ 1
#>     rx_pred_f_ ~ ipre
#>     rx_pred_ ~ rx_pred_f_
#>     rx_r_ ~ (add.sd)^2
#> })

f %>%
  model(ipre ~ add(f2)) ->
  tmp2

tmp2$foceiModel0
#> rxModelVars({
#>     tke <- THETA[1]
#>     eta.ke <- ETA[1]
#>     ke <- tke * exp(eta.ke)
#>     ipre <- 10 * exp(-ke * t)
#>     f2 <- ipre/(ipre + 5)
#>     f3 <- f2 * 3
#>     lipre <- log(ipre)
#>     rx_yj_ ~ 2
#>     rx_lambda_ ~ 1
#>     rx_low_ ~ 0
#>     rx_hi_ ~ 1
#>     rx_pred_f_ ~ ipre
#>     rx_pred_ ~ rx_pred_f_
#>     rx_r_ ~ f2
#> })

Created on 2022-01-21 by the reprex package (v2.0.0)

@mattfidler
Copy link
Member Author

It shoud be rx_r ~ f2^2

mattfidler added a commit that referenced this issue Jan 21, 2022
@mattfidler
Copy link
Member Author

library(nlmixr2)

f <- function() {
  ini({
    tke <- 0.5
    eta.ke ~ 0.04
    prop.sd <- sqrt(0.1)
  })
  model({
    ke <- tke * exp(eta.ke)
    ipre <- 10 * exp(-ke * t)
    f2 <- ipre / (ipre + 5)
    f3 <- f2 * 3
    lipre <- log(ipre)
    ipre ~ prop(prop.sd)
  })
}

f %>%
  model(ipre ~ add(add.sd)) ->
  tmp1

tmp1$foceiModel0
#> rxModelVars({
#>     tke <- THETA[1]
#>     add.sd <- THETA[2]
#>     eta.ke <- ETA[1]
#>     ke <- tke * exp(eta.ke)
#>     ipre <- 10 * exp(-ke * t)
#>     f2 <- ipre/(ipre + 5)
#>     f3 <- f2 * 3
#>     lipre <- log(ipre)
#>     rx_yj_ ~ 2
#>     rx_lambda_ ~ 1
#>     rx_low_ ~ 0
#>     rx_hi_ ~ 1
#>     rx_pred_f_ ~ ipre
#>     rx_pred_ ~ rx_pred_f_
#>     rx_r_ ~ (add.sd)^2
#> })

f %>%
  model(ipre ~ add(f2)) ->
  tmp2

tmp2$foceiModel0
#> rxModelVars({
#>     tke <- THETA[1]
#>     eta.ke <- ETA[1]
#>     ke <- tke * exp(eta.ke)
#>     ipre <- 10 * exp(-ke * t)
#>     f2 <- ipre/(ipre + 5)
#>     f3 <- f2 * 3
#>     lipre <- log(ipre)
#>     rx_yj_ ~ 2
#>     rx_lambda_ ~ 1
#>     rx_low_ ~ 0
#>     rx_hi_ ~ 1
#>     rx_pred_f_ ~ ipre
#>     rx_pred_ ~ rx_pred_f_
#>     rx_r_ ~ (f2)^2
#> })

Created on 2022-01-21 by the reprex package (v2.0.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant