integrate and refactor ThrowIfNull- fixes #5055 #5068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! |
This PR introduces a backward compatible way to use `ThrowIfNull` to check if the given argument is null and throw an exception or simply return the value of the argument.
r-52
force-pushed
the
feature/r-apply-throw-if-null
branch
from
73db656
to
8f5b9ff
Compare
|
SonarCloud Quality Gate failed. |
|
Think it looks good. Just need a single unit-test that verifies that |
|
Doesn't sound like a bad idea to also include |
|
@r-52 , is there a reason the file is called guard? shouldn't it be something like NullExecptionHandler? |
|
Superseeded by #5211 - Thank you for providing this initial code-suggestion, it helped getting the ball rolling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a backward compatible way to use
ThrowIfNullto check if the given argument is null andthrow an exception or simply return the value of the argument.
This is a draft PR to get initial feedback. It implements a backward compatible attribute that's used on .NET 5 and lower. The checks are an example how it could be used in the Logger.cs class.
An idea that came: maybe the
Guardclass could be extended to also integrate more checks likeThrowIfNullOrEmptyfor e.g. strings?R=@snakefoot?
Refs: #5055