Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cocoapod integration #1148

Closed
graph opened this issue Jun 27, 2018 · 11 comments
Closed

cocoapod integration #1148

graph opened this issue Jun 27, 2018 · 11 comments
Assignees
Milestone

Comments

@graph
Copy link

graph commented Jun 27, 2018

Is this ok? If I do it can I push to this repo? I want to be able to more easily use this library on ios. Perhaps under the pod njson.

@nlohmann
Copy link
Owner

That would be great, but I'd rather have a name like nlohmann_json, because this name is used with other package managers. See https://github.com/nlohmann/json#integration for an overview.

@graph
Copy link
Author

graph commented Jun 27, 2018

and published https://cocoapods.org/pods/nlohmann_json

It's easy to add additional authors, for now I just put you. I didn't put your email. If you want me to update the list in anyway let me know. It's also very easy to do so yourself in the podspec file. The programming language of the podspec is ruby.

@nlohmann
Copy link
Owner

Thanks for taking care of this! Is PR #1150 needed after all if the library is already published?

@graph
Copy link
Author

graph commented Jun 28, 2018

your welcome. Theoretically PR is not needed. But it's good to keep all integration files in the main repo.

@nlohmann
Copy link
Owner

I'd rather have the file in a repo controlled by the package maintainer (which I do not want to be). I cannot provide support for tools I do not use.

@graph
Copy link
Author

graph commented Jun 29, 2018

I understand no worries. It will probably be good to add to your readme something like

If you are using cocoapods, you can use the unofficial pod by adding pod "nlohmann_json", '~>3.1.2' to your podfile.

@nlohmann
Copy link
Owner

Alright. Do you have a repository where you keep the pod? Then I can link it if someone has issues. Furthermore, I would need such an issue tracker to notify you about new releases.

@graph
Copy link
Author

graph commented Jun 29, 2018

Happy Canada day. I'll set something up next week. In the mean time I will enjoy long weekend :)

@nlohmann
Copy link
Owner

nlohmann commented Jul 5, 2018

I would also need a small running example (something demonstrating how to compile a small program using the library) for the pod.

@graph
Copy link
Author

graph commented Jul 5, 2018

Ok I added a sample project too. I have set it up on my bitbucket, as nlohmann_json-cocoapod. People can submit issues there in the issue tracker

@nlohmann nlohmann self-assigned this Jul 5, 2018
@nlohmann nlohmann added this to the Release 3.1.3 milestone Jul 5, 2018
nlohmann added a commit that referenced this issue Jul 5, 2018
@nlohmann
Copy link
Owner

nlohmann commented Jul 5, 2018

Thanks a lot!

@nlohmann nlohmann closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants