cocoapods integration #1150
Closed
cocoapods integration #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to put the source files in a different directory? |
|
yes where do you want the dummy source files to be? |
|
interesting dummy files aren't needed. I was using an older version of cocoapods. It seems cocoapods linter is passing with just header only. |
nlohmann
requested changes
Jun 28, 2018
nlohmann_json.podspec
Outdated
| # ――― Spec Metadata ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――― # | ||
| s.name = "nlohmann_json" | ||
| s.version = "3.1.2" | ||
| s.summary = "JSON reader & writer for C++ optimized for ease of use and modern C++14" |
There was a problem hiding this comment.
That's not really the summary of the library. Please use "JSON for Modern C++" or something. And the library also supports C++11.
nlohmann_json.podspec
Outdated
|
|
||
| # CocoaPods strips indentation for description | ||
| s.description = <<-DESC | ||
| JSON library for c++, it can read & write, uses C++14 features to have |
nlohmann_json.podspec
Outdated
|
|
||
|
|
||
| s.authors = { | ||
| "Niels Lohmann" => "nosend@respectmyprivacy.com" |
There was a problem hiding this comment.
My email address is mail@nlohmann.me.
nlohmann_json.podspec
Outdated
| # the deployment target. You can optionally include the target after the platform. | ||
| # | ||
|
|
||
| s.platform = :ios, "8.0" |
There was a problem hiding this comment.
macOS should also be fine, right?
There was a problem hiding this comment.
I only tested iOS, theoretically it should be fine on macOS, watch and all other platforms. I don't want to add untested platforms.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds cocoapods integration so it can be used as a pod. See issue #1148